Skip to content

Conversation

tiero
Copy link
Member

@tiero tiero commented Aug 1, 2025

Summary

  • add a flutter_wallet_example folder containing a sample Flutter app and a minimal FFI Rust crate
  • document how the example connects to https://mutinynet.arkade.sh

Testing

  • cargo test --all --no-run

Copy link

coderabbitai bot commented Aug 1, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/add-folder-for-flutter-wallet-example

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, this is not that easy if we do not want to keep updating the Flutter FFI with every small change in everything.

I spend a lot of time thinking about this kind of libraries for rust when I was designing lampo, and I think the best way is writing the library in rust as a separate module like arkade-ffi where there is a rust implementation of the API that we want to expose to the user, then use https://pub.dev/packages/flutter_rust_bridge to generate the dart package

An example is https://github.com/vincenzopalazzo/lampo.rs/blob/main/lampo-c-ffi/src/lib.rs

This allow you to keep the type safety of rust because the you need to check only the function parameters, then implement a better error handling that will be lost otherwise (or will be very difficult to keep across ffi channels due the Option vs Exceptions)

@tiero
Copy link
Member Author

tiero commented Aug 4, 2025

my goal wasn't to have a solution for production apps or either merge it, just wanted to have a single place I can point people with Rust & Flutter experience what to look into and how the bindings would look like and ability to start hacking on it.

At the moment we don't have plans to start a native dart library (pending MuSig2 support) or either official Flutter bindings, so I would postpone the decision and leave to external contributor to iterate on it.

Thank you for the insights

@bonomat
Copy link
Collaborator

bonomat commented Aug 5, 2025

@tiero : is your intention to move https://github.com/ArkLabsHQ/ark-flutter-example into this repository?

@tiero
Copy link
Member Author

tiero commented Aug 5, 2025

@tiero : is your intention to move https://github.com/ArkLabsHQ/ark-flutter-example into this repository?

I wanted to have a barebone example close to the actual code here, I was not thinking of a full fledged flutter app. Open to proposals to simplify eventually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants